New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make mobile app great again #96

Merged

gomesalexandre merged 38 commits into main from feat_make_mobile_app_great_again

May 31, 2024

Contributor

gomesalexandre commented May 14, 2024 •

edited

Loading

This PR:

adds walletconnect's react-native compatbility layer
removes injected JS console forwarding eval'd code
does some housekeeping while in here

In effect, this fixes shapeshift/web#6766 and https://shapeshift-dao.sentry.io/issues/252824 / https://shapeshift-dao.sentry.io/issues/253532 / https://shapeshift-dao.sentry.io/issues/253784:

Screenshot 2024-05-14 at 22 23 15

Screenshot 2024-05-14 at 22 24 20

Screenshot 2024-05-14 at 22 24 29

gomesalexandre added 6 commits

May 14, 2024 18:46


          feat: add react-native walletconnect compatibility layer

5d3b798


          feat: react-native-get-random-values too

9bd08e2


          feat: honor README

7d106b9


          feat: add .git-blame-ignore-revs

d65d2de


          feat: onCreate WebView.setWebContentsDebuggingEnabled(true)

9afdf61


          feat: what the fuck was that

6f9627b

gomesalexandre commented

View reviewed changes

.git-blame-ignore-revs Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

.env.template Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

android/app/src/main/java/com/shapeshift/MainActivity.java Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

package.json Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

package.json Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

src/App.tsx Outdated Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

src/lib/console.ts Show resolved Hide resolved


          feat: more cleanup

dabb829

gomesalexandre commented

View reviewed changes

src/lib/getMessageManager.ts Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

src/lib/getMessageManager.ts Show resolved Hide resolved

gomesalexandre commented

View reviewed changes

types/react-native-dotenv.d.ts Show resolved Hide resolved


          feat: add debugging instructions

0934d1e

gomesalexandre requested a review from 0xean

May 14, 2024 20:30

woodenfurniture reviewed

View reviewed changes

src/App.tsx Outdated Show resolved Hide resolved

gomesalexandre and others added 10 commits

May 15, 2024 01:13


          feat: setWebContentsDebuggingEnabled(true) in debug builds only

c02c20e


          feat: add commentary and move out of regular imports for clarity

78d0846


          fix: missing import

8f530ac


          feat: rm compat layer

d9cfb87


          feat: cleanup package.json

b8823c9


          feat: hell

d9915f5


          feat: i don't even know what I'm diffing at this point

f62aad2


          feat: what the fuck?

59f8566


          feat: rm react-native-compat

7b899fa


          fix: update every packages needed and patch android style

0e991ce

Contributor

0xean commented May 17, 2024

Currently when attempting to test this on android, the wallet connect does initially connect, but then the screen is cut off so I am unable to go through the pairing flow. This is probably not related to this ticket, but hard to test with this. Here is a screen recording and I will see if a different emulated device fixes this.

Screen.Recording.2024-05-17.at.4.04.00.PM.mov

Note, there is no ability to scroll down.

Contributor

0xean commented May 17, 2024

Tried this on a Pixel_7 with API 33 - same diff, just more real estate

So unable to test the flow fully

0xean mentioned this pull request

feat: react-native hell #97

Merged

2 tasks

gomesalexandre added 3 commits

May 20, 2024 17:41


          feat: add wc URIs to shouldLoadFilter

8d476ea


          feat: bump minSdkVersion to 33

27bf1a1


          feat: regen Podfile

1d2ba10

NeOMakinG mentioned this pull request

fix: enable scroll when menu drawer is opened shapeshift/web#6955

Merged

3 tasks

NeOMakinG and others added 17 commits

May 21, 2024 22:43


          fix: restore packages identifiers and fix a few icons and colors

c36f418


          fix: icon size

a0396f6


          feat: regen podfile and project.pbxproj after pod install

84915d3


          feat: npx expo prebuild

8fa319c


          fix: wrong changes

c7091ee


          feat: bump again (again)

6e1b4c7


          fix: use config without importing

3e4e557


          fix: proper app name for the ios build

c96fbff


          fix: make xcode great again and ios bundle name change


          fix: change prod bundle name

c98f118


          fix: reset default component name

89df9aa


          fix: review

a3425a1


          feat: update Podfile after nuke and clean rebuild

17c56fa


          Merge pull request #97 from shapeshift/feat_mobile_app_bumps

c7e11a4


          feat: make lint great again

dd4f5b6


          feat: make types great again (ish, many ignores for sanity)

081d4db


          feat: ffs eslint-disable-next-line on ts-ignore, I know what I'm doing

10a421d

0xean approved these changes

View reviewed changes

gomesalexandre merged commit 3df8dfc into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet